changed: background file manager operations #1541

Merged
6 commits merged into from Oct 6, 2012

3 participants

@ghost

As in the topic. I could probably split this a bit if you insist, but it got so damm entangled..

@ghost

this depends on pr #1530

@opdenkamp
Team Kodi member

nice

@ghost

better split now and no longer depends on #1530

@jmarshallnz
Team Kodi member

Looks good to me. A few functions could be const (You asked for it by changing one that wasn't related...)

@ghost ghost was assigned Oct 4, 2012
@ghost

hah, as if i'd ever do such a thing ;) put it in the correct context now + made the new functions const.

@ghost

no other concerns?

@dersphere
Team Kodi member

If you are interested in a user opinion: I would like it even more if it would copy or move files one after another with any kind of queue and not parallel.

@ghost

it's sorta what it does. it does two user-initiated operations in parallel. an operation can be copying n files or n dirs or whatever.

@dersphere
Team Kodi member

Oh, looks like I was not precise enough - sorry.
When I start copying file A and then start copying file B, both copy-jobs are done at the same time (and the progress window switches between the jobs).

@ghost

i got you. if, however, you mark file a and file b and hit copy, they will be copied in sequence. doing it all in sequence is trivial, that's just removing the 2 thread slots. but imo this is better.

@ghost ghost merged commit f69f18c into xbmc:master Oct 6, 2012
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment