Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[python] fix usage of line-breaks in ok dialog #15434

Merged
merged 1 commit into from Feb 17, 2019

Conversation

Projects
None yet
3 participants
@ronie
Copy link
Member

commented Feb 5, 2019

fix the usage of line-breaks in a python ok dialog.
when a single line of text is passed to the dialog, the ShowOKDialogText helper should be used.

the fixes issue #14824

issue was introduced by PR #10893

@MartijnKaijser

This comment has been minimized.

Copy link
Member

commented Feb 6, 2019

Jenkins build this please

1 similar comment
@MartijnKaijser

This comment has been minimized.

Copy link
Member

commented Feb 10, 2019

Jenkins build this please

@MartijnKaijser

This comment has been minimized.

Copy link
Member

commented Feb 10, 2019

@enen92 can you check?

@enen92

This comment has been minimized.

Copy link
Member

commented Feb 14, 2019

I'll take a look tonight

@enen92

enen92 approved these changes Feb 14, 2019

@MartijnKaijser MartijnKaijser added this to the Leia 18.2-rc1 milestone Feb 15, 2019

@MartijnKaijser MartijnKaijser merged commit 6342415 into xbmc:master Feb 17, 2019

1 check passed

default You're awesome. Have a cookie
Details

@ronie ronie deleted the ronie:python-ok branch May 7, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.