Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "[DetectDVDType]: fix Crash due to non-checked error state" #15476

Merged
merged 1 commit into from Feb 10, 2019

Conversation

@Memphiz
Copy link
Member

commented Feb 9, 2019

Reverts #14842

I have to revert that fix. The problem is that getting the tray state on some Macs results in "operation unsupported". This now results in the fact that no media is detected. Without the fix it will work because of the default initialization of the tray state to "closed with media".

The original crash that was fixed here happened due to the fact that the user uses an Toshiba usb hdd which presents itself as an virtual cd drive (which holds the usb hdd manual and crap like that). libcdio choked and crashed on that virtual drive.

I'd rather support real cd/dvd drives then supporting a single users with broken HDDs. So here is my revert.

@MartijnKaijser

This comment has been minimized.

Copy link
Member

commented Feb 10, 2019

Jenkins build this please

@MartijnKaijser MartijnKaijser added this to the Leia 18.1-rc1 milestone Feb 10, 2019
@MartijnKaijser MartijnKaijser merged commit 4f7cb48 into master Feb 10, 2019
1 check passed
1 check passed
default You're awesome. Have a cookie
Details
@Rechi Rechi added the v18 Leia label Feb 10, 2019
@Rechi Rechi deleted the revert-14842-cdio_checkerror branch Feb 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.