Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wake on access: fix crash on startup #15491

Merged
merged 1 commit into from Mar 1, 2019

Conversation

Projects
None yet
4 participants
@vpeter4
Copy link
Contributor

commented Feb 11, 2019

Description

When using path substitution and wake-on-lan Kodi crashes on start because GUI is not yet created.

Motivation and Context

Allows to use wake-on-lan when also path substitution is used.
Log: http://ix.io/1Af1

How Has This Been Tested?

Using custom build of LibreELEC 9.0 x86_64 with both features used.

Screenshots (if appropriate):

Types of change

  • Bug fix (non-breaking change which fixes an issue)
  • Clean up (non-breaking change which removes non-working, unmaintained functionality)
  • Improvement (non-breaking change which improves existing functionality)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that will cause existing functionality to change)
  • Cosmetic change (non-breaking change that doesn't touch code)
  • None of the above (please explain below)

Checklist:

  • My code follows the Code Guidelines of this project
  • My change requires a change to the documentation, either Doxygen or wiki
  • I have updated the documentation accordingly
  • I have read the Contributing document
  • I have added tests to cover my change
  • All new and existing tests passed
wake on access: fix crash on startup
When Kodi starts there is no GUI yet.
log file: http://ix.io/1Af1
@lrusak

lrusak approved these changes Feb 11, 2019

@lrusak

This comment has been minimized.

Copy link
Contributor

commented Feb 11, 2019

Thanks! LGTM

@vpeter4

This comment has been minimized.

@Rechi Rechi added this to the Leia 18.2-rc1 milestone Feb 27, 2019

@MartijnKaijser MartijnKaijser merged commit 413835c into xbmc:master Mar 1, 2019

1 check passed

default You're awesome. Have a cookie
Details

@vpeter4 vpeter4 deleted the vpeter4:wakeonaccess branch Mar 1, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.