Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs/README.Fedora] fixes and updates #15510

Merged
merged 1 commit into from Mar 1, 2019

Conversation

Projects
None yet
4 participants
@DaVukovic
Copy link
Member

commented Feb 13, 2019

Description

Fixed a typo and I also added flatbuffers-devel as a dep, becuase I needed to install it to be able to configure. Not sure if flatbuffers is needed then as I haven't tried removing it.

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of change

  • Bug fix (non-breaking change which fixes an issue)
  • Clean up (non-breaking change which removes non-working, unmaintained functionality)
  • Improvement (non-breaking change which improves existing functionality)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that will cause existing functionality to change)
  • Cosmetic change (non-breaking change that doesn't touch code)
  • None of the above (please explain below)

Checklist:

  • My code follows the Code Guidelines of this project
  • My change requires a change to the documentation, either Doxygen or wiki
  • I have updated the documentation accordingly
  • I have read the Contributing document
  • I have added tests to cover my change
  • All new and existing tests passed
@Rechi

This comment has been minimized.

Copy link
Member

commented Feb 13, 2019

Not sure if flatbuffers is needed then as I haven't tried removing it.

Both the flatbuffers headers (flatbuffers-devel) and the flatbuffers compiler (flatbuffers) are required for building Kodi.

@MartijnKaijser

This comment has been minimized.

Copy link
Member

commented Mar 1, 2019

Good to merge?

@hudokkow hudokkow merged commit 35d79dc into xbmc:master Mar 1, 2019

@Rechi Rechi added this to the Leia 18.2-rc1 milestone Mar 1, 2019

@DaVukovic DaVukovic deleted the DaVukovic:fedora branch Mar 1, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.