Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Windowing] Build complete strmode for RES_DESKTOP #15516

Merged
merged 1 commit into from Feb 17, 2019

Conversation

Projects
None yet
4 participants
@peak3d
Copy link
Contributor

commented Feb 14, 2019

Description

Build complete strmode for RES_DESKTOP

Motivation and Context

Calibration changes are currently not applied to the resolution after kodi termination because of non-matching strMode in RES_DESKTOP.

#15165
#15508

How Has This Been Tested?

Win10, change sub position in settings::display::calibrations, restart kodi

Types of change

  • Bug fix (non-breaking change which fixes an issue)
  • Clean up (non-breaking change which removes non-working, unmaintained functionality)
  • Improvement (non-breaking change which improves existing functionality)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that will cause existing functionality to change)
  • Cosmetic change (non-breaking change that doesn't touch code)
  • None of the above (please explain below)

@afedchin ping....

@peak3d peak3d added this to the Leia 18.2-rc1 milestone Feb 14, 2019

@peak3d peak3d force-pushed the peak3d:calibration branch 3 times, most recently from f52e6a9 to 00affc9 Feb 14, 2019

@yuri-sevatz

This comment has been minimized.

Copy link

commented Feb 15, 2019

Only thing I'd suggest is maybe changing RES_DESKTOP + 1 to RES_CUSTOM, so that first loop makes it explicit what it's trying to loop through:

https://github.com/xbmc/xbmc/pull/15516/files#diff-fdf8a0ecba6648be7362d3a49502479cR557

^^ Doing that isn't imperative for this fix, but it's probably not safe to keep differences between those constants scattered throughout the .cpp, lol

@peak3d peak3d force-pushed the peak3d:calibration branch from 00affc9 to 31087b1 Feb 15, 2019

@peak3d peak3d changed the title [Windows] Build complete strmode for RES_DESKTOP [Windowing] Build complete strmode for RES_DESKTOP Feb 15, 2019

@peak3d peak3d merged commit 46f2c88 into xbmc:master Feb 17, 2019

1 check passed

default You're awesome. Have a cookie
Details

@peak3d peak3d deleted the peak3d:calibration branch Feb 17, 2019

@Essam315

This comment has been minimized.

Copy link

commented Feb 19, 2019

@peak3d
My windows 10 is 32 bit, and can not test the nightly because the last nightly was from 17 Feb.

@peak3d

This comment has been minimized.

Copy link
Contributor Author

commented Feb 19, 2019

@Essam315 yes we arrive issues in our automated build system currently.

@Essam315

This comment has been minimized.

Copy link

commented Feb 20, 2019

@peak3d
Thank you so much, the problem of losing the video calibration settings after a restart is fixed for me with this nightly, Kodi 18.2 Leia.

https://mirror.de.leaseweb.net/xbmc/nightlies/windows/win32/master/KodiSetup-20190219-d21fed4a-master-x86.exe

@afedchin

This comment has been minimized.

Copy link
Member

commented Feb 20, 2019

@Essam315 please use forum for asking devs. GH isn't right place for asking.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.