Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[skins] prefer poster over thumb to match design #15543

Merged
merged 1 commit into from Feb 21, 2019

Conversation

Projects
None yet
4 participants
@rmrector
Copy link
Contributor

commented Feb 17, 2019

Description

When the image is designed for a poster (taller than wide), prefer a poster directly instead of using "Thumb" fallback to poster. Both Estuary and Estouchy updated.

Motivation and Context

When the skin is designed to display a poster, display it even if there is also a thumbnail.

How Has This Been Tested?

Quick run through the GUI, items with and without thumbnails and/or posters.

Screenshots (if appropriate):

before

image

after

image

Types of change

  • Bug fix (non-breaking change which fixes an issue)
  • Clean up (non-breaking change which removes non-working, unmaintained functionality)
  • Improvement (non-breaking change which improves existing functionality)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that will cause existing functionality to change)
  • Cosmetic change (non-breaking change that doesn't touch code)
  • None of the above (please explain below)

Checklist:

  • My code follows the Code Guidelines of this project
  • My change requires a change to the documentation, either Doxygen or wiki
  • I have updated the documentation accordingly
  • I have read the Contributing document
  • I have added tests to cover my change
  • All new and existing tests passed

@rmrector rmrector requested review from KarellenX, ronie, phil65 and HitcherUK and removed request for KarellenX Feb 17, 2019

@ronie

ronie approved these changes Feb 21, 2019

Copy link
Member

left a comment

changes look good to me. thx!

@MartijnKaijser MartijnKaijser merged commit 3e5bf6a into xbmc:master Feb 21, 2019

@Rechi Rechi added the v18 Leia label Feb 21, 2019

@Rechi Rechi added this to the Leia 18.2-rc1 milestone Feb 21, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.