Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Android] Implement MediaDRM provisioning #15553

Merged
merged 1 commit into from Feb 19, 2019

Conversation

Projects
None yet
2 participants
@peak3d
Copy link
Contributor

commented Feb 19, 2019

Description

The initial use of widevine DRM requires device provisioning for L1 protection level.
This PR imlements the provisioning handling for MediaDrmCryptoSession

Motivation and Context

On new devices NX addon fails until the first widevine protected video was played successfully.
Reason is that device provisioning is implemented in inputstream.adaptive, but not (yet) in MediaDrmCryptoSession which i part of kodi.

How Has This Been Tested?

Tests will be done by afected users, see here: peak3d/inputstream.adaptive#228

Types of change

  • Bug fix (non-breaking change which fixes an issue)
  • Clean up (non-breaking change which removes non-working, unmaintained functionality)
  • Improvement (non-breaking change which improves existing functionality)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that will cause existing functionality to change)
  • Cosmetic change (non-breaking change that doesn't touch code)
  • None of the above (please explain below)
@peak3d

This comment has been minimized.

Copy link
Contributor Author

commented Feb 19, 2019

jenkins build this please

2 similar comments
@peak3d

This comment has been minimized.

Copy link
Contributor Author

commented Feb 19, 2019

jenkins build this please

@peak3d

This comment has been minimized.

Copy link
Contributor Author

commented Feb 19, 2019

jenkins build this please

@peak3d peak3d force-pushed the peak3d:crypto branch from 4edd132 to 90f67c0 Feb 19, 2019

@peak3d

This comment has been minimized.

Copy link
Contributor Author

commented Feb 19, 2019

jenkins build this please

@peak3d peak3d merged commit d21fed4 into xbmc:master Feb 19, 2019

1 check passed

default You're awesome. Have a cookie
Details

@peak3d peak3d deleted the peak3d:crypto branch Feb 19, 2019

else
{
provisioned = true;
goto TRYAGAIN;

This comment has been minimized.

Copy link
@a1rwulf

a1rwulf Feb 20, 2019

Member

You leak a CharVecBuffer instance for every retry now, right?

This comment has been minimized.

Copy link
@peak3d

peak3d Feb 20, 2019

Author Contributor

Thanks for the hint, I'll change but its not critical because provisioning is done exactly once per device after factory reset.

This comment has been minimized.

Copy link
@a1rwulf

a1rwulf Feb 20, 2019

Member

Yeah np, just catched it by accident ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.