Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Android] change intent management in java::main #15556

Merged
merged 1 commit into from Feb 19, 2019

Conversation

Projects
None yet
1 participant
@peak3d
Copy link
Contributor

commented Feb 19, 2019

Description

Intents arriving java main class are currently stored using a single class member.
But they are send to kodi native interface delayed. IMO there is a risk that the intent will be invalidated during processing. This PR tries to fix this using an intent stack.

Motivation and Context

Still many intent / broadcast exceptions in google playstore analytics

How Has This Been Tested?

Not tested, because issue can not be reproduced

Types of change

  • Bug fix (non-breaking change which fixes an issue)
  • Clean up (non-breaking change which removes non-working, unmaintained functionality)
  • Improvement (non-breaking change which improves existing functionality)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that will cause existing functionality to change)
  • Cosmetic change (non-breaking change that doesn't touch code)
  • None of the above (please explain below)

@peak3d peak3d added this to the Leia 18.2-rc1 milestone Feb 19, 2019

@peak3d peak3d merged commit ac300fc into xbmc:master Feb 19, 2019

1 check passed

default You're awesome. Have a cookie
Details

@peak3d peak3d deleted the peak3d:intent branch Feb 19, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.