Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

[pvr] Fix recording resume (and check the correct addon-capability) #1557

merged 2 commits into from Oct 8, 2012


None yet
2 participants

mikkle commented Oct 6, 2012

"Resume from" is broken for pvr recordings.
The PR contains two commits: 08211a9 fixes a check against the (I believe) wrong capability, and c8231cf does the actual fix of recording resumepoints.
I have kept it as separate commits for clarity. Will squash if deemed necessary.

mikkle added some commits Oct 6, 2012

[pvr] fix: Check for SupportsLastPlayedPosition instead of SupportsRe…
…cordingPlayCount when getting/setting last played position for recording.
[pvr] Fix get last played position for recording: use -1 instead of 0…
… as default rc for GetRecordingLastPlayedPosition as 0 is treated as a valid resumepoint, whereas -1 is not.

opdenkamp pushed a commit that referenced this pull request Oct 8, 2012

Merge pull request #1557 from mikkle/fix-recording-resume
[pvr] Fix recording resume (and check the correct addon-capability)

@opdenkamp opdenkamp merged commit f13566b into xbmc:master Oct 8, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment