Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Android] Post instead SendMessage to stop playing on SCREEN_OFF #15574

Merged
merged 1 commit into from Feb 22, 2019

Conversation

Projects
None yet
1 participant
@peak3d
Copy link
Contributor

commented Feb 21, 2019

Description

On SCREEN_OFF intent we SendMessage a stopPlaying message to the main thread which can lock the render workflow. PostMessage solves this lock.

Motivation and Context

ANR count in google play store

How Has This Been Tested?

Play video on phone, switch display off / on.

Types of change

  • Bug fix (non-breaking change which fixes an issue)
  • Clean up (non-breaking change which removes non-working, unmaintained functionality)
  • Improvement (non-breaking change which improves existing functionality)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that will cause existing functionality to change)
  • Cosmetic change (non-breaking change that doesn't touch code)
  • None of the above (please explain below)
@peak3d

This comment has been minimized.

Copy link
Contributor Author

commented Feb 22, 2019

Lnux-64-wayland unrelated.

@peak3d peak3d merged commit 10dae1a into xbmc:master Feb 22, 2019

1 check failed

default Sorry, building this PR failed. Please check the logs for the errors.
Details

@peak3d peak3d deleted the peak3d:screenoff branch Feb 22, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.