Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

[webinterface] Core.js - cleanup - no more global variables #1559

Merged
merged 1 commit into from Oct 7, 2012

Conversation

Projects
None yet
2 participants
Contributor

asylumfunk commented Oct 6, 2012

  • removed unused prototype definitions
  • explicitly access the local window
  • cleaned up logic, declared all implied variables
  • renamed file to follow convention
  • updated copyright year
@asylumfunk asylumfunk cleanup - no more global variables
- removed unused prototype definitions
- explicitly access the local window
- cleaned up logic, declared all implied variables
- renamed file to follow convention
- updated copyright year
fb58bfa

@Montellese Montellese was assigned Oct 6, 2012

Owner

Montellese commented Oct 7, 2012

I'm pro anything that improves the default webinterface because basically nobody cares about it. I just fix up the JSON-RPC requests if I change anything in JSON-RPC but that's all the love it ever gets.

PS: for future commits/PRs could you add a "[webinterface.default]" or something like that at the beginning of your commit messages. Makes it easier to know what area the commits affect if looking through the list of commits. Just an FYI.

Contributor

asylumfunk commented Oct 7, 2012

Will do, regarding future PRs.

As far as the "neglect" for this addon, I figured as much. That's actually exactly what brought me here :) I was using the webinterface, decided to pull up the source in my browser one day and thought, "this doesn't look like it's been touched in years." Of course, the commit log here verified that. I've privately forked this project a few times, but never ended up polishing/releasing them. This time around, I figured, why not share back with the community?

I've got a couple more minor performance changes/cleanups lined up for this window (one depends on this PR) that I'll submit today/tomorrow. Outside of all the low-hanging fruit, I'm working on series of larger, further reaching changes (I may get the first completed for this window; we'll see today..) to drastically improve performance/experience. After that, I'll move on to updating the UI/display, but one step at a time... :)

@Montellese Montellese added a commit that referenced this pull request Oct 7, 2012

@Montellese Montellese Merge pull request #1559 from asylumfunk/core.js
[webinterface.default] Core.js cleanup: no more global variables
e8251ea

@Montellese Montellese merged commit e8251ea into xbmc:master Oct 7, 2012

Owner

Montellese commented Oct 7, 2012

Hehe well the only reason I ever touched it was because I broke its functionality with changes in JSON-RPC. My web developer days are long gone (8-10 years now) and I'm anything but up-to-date on JavaScript. Back in the days there was no jQuery et. al. to do all these fancy animations etc ;-)
IIRC @da-anda had some ideas on the UI side of things for the webinterface and mizaki has offered to help out as well either by using the AWXi webinterface as the default one or by using parts of it's code for the default webinterface. Maybe you could open up a thread in the developer forum about talk on the webinterface for those interested in working on it and also sharing what you already got and what you plan to do.

@LongChair LongChair added a commit to plexinc/plex-home-theater-public that referenced this pull request May 25, 2015

@LongChair LongChair Allow to have unplayed episodes to be reset to unwatched when they ar…
…e partially watched, fixes #1559
54f54ee
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment