Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Const correct audioengine #15595

Merged
merged 3 commits into from Feb 23, 2019

Conversation

Projects
None yet
3 participants
@rikardfalkeborn
Copy link
Contributor

commented Feb 23, 2019

Description

Add const to member functions.

How Has This Been Tested?

Compile tested on Linux.

Types of change

  • Bug fix (non-breaking change which fixes an issue)
  • Clean up (non-breaking change which removes non-working, unmaintained functionality)
  • Improvement (non-breaking change which improves existing functionality)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that will cause existing functionality to change)
  • Cosmetic change (non-breaking change that doesn't touch code)
  • None of the above (please explain below)

Checklist:

  • My code follows the Code Guidelines of this project
  • My change requires a change to the documentation, either Doxygen or wiki
  • I have updated the documentation accordingly
  • I have read the Contributing document
  • I have added tests to cover my change
  • All new and existing tests passed

@Rechi Rechi requested a review from fritsch Feb 23, 2019

@fritsch

This comment has been minimized.

Copy link
Member

commented Feb 23, 2019

Thanks much. This is good practice to make methods const to keep the "const state" of the object those methods belong to. If we changed something in the future that would have a side-effect when calling these the compiler would directly warn.

Fine with me!

@fritsch
Copy link
Member

left a comment

Thanks much.

@Rechi Rechi added this to the Leia 18.2-rc1 milestone Feb 23, 2019

@Rechi Rechi merged commit c275da3 into xbmc:master Feb 23, 2019

1 check passed

default You're awesome. Have a cookie
Details
@rikardfalkeborn

This comment has been minimized.

Copy link
Contributor Author

commented Feb 23, 2019

Hmm, seems the testrunner on FreeBSD core dumped

19:00:34 /home/jenkins/workspace/FreeBSD/tools/buildsteps/freebsd/run-tests: line 10: 71307 Abort trap              (core dumped) build/kodi-test --gtest_output=xml:gtestresults.xml

I couldn't see any other builds where this happened, but I can't really figure out why this change would cause a core dump....

@rikardfalkeborn rikardfalkeborn deleted the rikardfalkeborn:const-correct-audioengine branch Feb 23, 2019

@Rechi

This comment has been minimized.

Copy link
Member

commented Feb 23, 2019

The test suite is a bit buggy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.