Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assign video library NFO thumb without aspect as poster #15598

Merged
merged 1 commit into from Feb 27, 2019

Conversation

Projects
None yet
2 participants
@rmrector
Copy link
Contributor

commented Feb 24, 2019

Description

Small adjustment to #12612 to keep backward-compatibility with video library NFOs for Kodi 11 Eden or exported from Kodi 11 Eden scrapers. Kodi only supported a single non-fanart image so thumbs didn't have an aspect attribute, but before #12612 it was mapped to "poster" for all media types except episodes, and this returns that behavior.

Motivation and Context

NFOs can be somewhat long lived, and keeping this behavior is simple enough at this point. Resolves #15514.

How Has This Been Tested?

Manually, scanning a few movies, TV shows, and episodes with and without the 'aspect' tag.

Screenshots (if appropriate):

Types of change

  • Bug fix (non-breaking change which fixes an issue)
  • Clean up (non-breaking change which removes non-working, unmaintained functionality)
  • Improvement (non-breaking change which improves existing functionality)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that will cause existing functionality to change)
  • Cosmetic change (non-breaking change that doesn't touch code)
  • None of the above (please explain below)

Checklist:

  • My code follows the Code Guidelines of this project
  • My change requires a change to the documentation, either Doxygen or wiki
  • I have updated the documentation accordingly
  • I have read the Contributing document
  • I have added tests to cover my change
  • All new and existing tests passed
Set NFO thumb without aspect as poster
Small adjustment to #12612 to keep backward-compatibility with
NFOs exported from Kodi 11 Eden scrapers.

@rmrector rmrector requested a review from notspiff Feb 26, 2019

@rmrector

This comment has been minimized.

Copy link
Contributor Author

commented Feb 27, 2019

Lazy spiff signed off on slack. 😪

@rmrector rmrector merged commit 2d89e22 into xbmc:master Feb 27, 2019

1 check passed

default You're awesome. Have a cookie
Details

@DaveTBlake DaveTBlake added this to the Leia 18.2-rc1 milestone Feb 27, 2019

@DaveTBlake

This comment has been minimized.

Copy link
Member

commented Feb 27, 2019

@rmrector remember to label and milestone, especially before merge

@rmrector

This comment has been minimized.

Copy link
Contributor Author

commented Feb 28, 2019

Whoops, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.