Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
Fixes a crash when a file's embedded art is invalid #15605
If a file's metadata contains embedded art and that art is not valid, kodi will crash when a user tries to edit the thumbnail from the Context Menu -> Information -> Choose Art -> Thumbnail. This patch checks to see that the m_info object is not null to prevent a crash.
Motivation and Context
This change is required to fix a crash when editing the thumbnail of a movie/episode that has invalid embedded art.
How Has This Been Tested?
Tested on MacOS with an mkv that has invalid embedded art and scanned to the library as a movie. Then from the movie library and the movie's context menu Information -> Choose Art -> Thumbnail was selected. This would previously cause the crash. With the patch, there is no longer a crash.
Screenshots (if appropriate):
Types of change
I am not sure if the invalid art is causing m_info to be nullptr. After I removed the art in the metadata, the crash stopped even without the patch. That could be because the metadata was re-written. I will try to find the true source. Either way though, the patch just makes sure that m_info is not null, which can happen.
It depends. If m_info shouldn't be