Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[videodb]fix: Return empty InfoTag when looking up non-existent music video #15614

Merged
merged 1 commit into from Mar 1, 2019

Conversation

Projects
None yet
4 participants
@rmrector
Copy link
Contributor

commented Feb 26, 2019

Description

Fix crash when looking up a non-existent music video by ID. Gives music videos the same null check that all other video library items already have.

Motivation and Context

Crash. #15613

How Has This Been Tested?

Manually. No crash.

Screenshots (if appropriate):

Types of change

  • Bug fix (non-breaking change which fixes an issue)
  • Clean up (non-breaking change which removes non-working, unmaintained functionality)
  • Improvement (non-breaking change which improves existing functionality)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that will cause existing functionality to change)
  • Cosmetic change (non-breaking change that doesn't touch code)
  • None of the above (please explain below)

Checklist:

  • My code follows the Code Guidelines of this project
  • My change requires a change to the documentation, either Doxygen or wiki
  • I have updated the documentation accordingly
  • I have read the Contributing document
  • I have added tests to cover my change
  • All new and existing tests passed

@rmrector rmrector added the Type: Fix label Feb 26, 2019

@MilhouseVH

This comment has been minimized.

Copy link
Contributor

commented Feb 26, 2019

Thanks, this now works as expected and resolves #15613.

@Rechi Rechi added this to the Leia 18.2-rc1 milestone Feb 26, 2019

@Rechi

Rechi approved these changes Feb 26, 2019

@MartijnKaijser MartijnKaijser merged commit 1ca9ef6 into xbmc:master Mar 1, 2019

1 check passed

default You're awesome. Have a cookie
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.