Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Android] rework intermediate stream start / flush #15622

Merged
merged 1 commit into from Feb 28, 2019

Conversation

Projects
None yet
2 participants
@peak3d
Copy link
Contributor

commented Feb 26, 2019

Description

From experiences / user reports in the last couple of weeks #15455 lead to issues on some devices. Even we bumped SDK to >=26 after first issues appeared, still issues remained.

From reading below linked issue, it is quite sure that h.265 decoder at least on users device needs to be fed initially with an I-Frame. Because BitstreamConverter is already open for h.264 / h.265 streams because of annexb convertion, it does not cost too much searching for an IFrame on decoding start.

Motivation and Context

https://forum.kodi.tv/showthread.php?tid=341201

How Has This Been Tested?

Tested on several devices playing h.264 and h.265 streams.
Because the "decoder goes in broken mode" issue could not be reproduced from my side, the change is not fully self - tested (but user did)

Screenshots (if appropriate):

Types of change

  • Bug fix (non-breaking change which fixes an issue)
  • Clean up (non-breaking change which removes non-working, unmaintained functionality)
  • Improvement (non-breaking change which improves existing functionality)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that will cause existing functionality to change)
  • Cosmetic change (non-breaking change that doesn't touch code)
  • None of the above (please explain below)

@peak3d peak3d force-pushed the peak3d:eos branch from fbdb60e to 57f3a8f Feb 28, 2019

@peak3d

This comment has been minimized.

Copy link
Contributor Author

commented Feb 28, 2019

jenkins build this please

@peak3d peak3d merged commit a1354ce into xbmc:master Feb 28, 2019

1 check passed

default You're awesome. Have a cookie
Details

@peak3d peak3d deleted the peak3d:eos branch Feb 28, 2019

@davebytes

This comment has been minimized.

Copy link

commented Mar 12, 2019

Just making sure to comment here and not just leave in email thread. We've found this in testing on SHIELD in many different situations, where resuming a previous playback (so like play, open recents, go to another app, open recents, come back to kodi) requires some kind of a 'rewind to keyframe' for most formats, as the hw decoder simply throws an error back if you try to start playback from an intermediate frame.

@peak3d

This comment has been minimized.

Copy link
Contributor Author

commented Mar 13, 2019

@davebytes have you seen this one: #15719 ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.