Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AESinkAudioTrack: Trace flush on deinitialize #15631

Merged
merged 1 commit into from Feb 28, 2019

Conversation

Projects
None yet
3 participants
@fritsch
Copy link
Member

commented Feb 27, 2019

Description

This helps the non-blocking Stop / Flush implementations on Android by waiting the Drain-Time when doing Deinitialize

Motivation and Context

Original issue was brought up here: #15601

How Has This Been Tested?

User tested opening / reopening of files. Works with the change, does not work without

Screenshots (if appropriate):

Types of change

This is in fact a workaround*

@peak3d

peak3d approved these changes Feb 27, 2019

Copy link
Contributor

left a comment

beside the typo I'm fine with that

@@ -290,7 +290,7 @@ bool CAESinkAUDIOTRACK::VerifySinkConfiguration(int sampleRate, int channelMask,
jniAt->release();
delete jniAt;
}

usleep(50 * 1000); // Enumeratiion only, reduce pressure while starting

This comment has been minimized.

Copy link
@peak3d

peak3d Feb 27, 2019

Contributor

typo

@peak3d peak3d referenced this pull request Feb 27, 2019

Open

Leia: (Partial) Video Playback issue on FTV 4K Stick #15143

1 of 1 task complete

@fritsch fritsch force-pushed the fritsch:androidextendedflush branch from 5b10e97 to 9953c5b Feb 28, 2019

@MartijnKaijser MartijnKaijser merged commit 94cb6ab into xbmc:master Feb 28, 2019

1 check passed

default You're awesome. Have a cookie
Details

@MartijnKaijser MartijnKaijser added this to the Leia 18.2-rc1 milestone Feb 28, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.