Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Music]Fix collaboration album tag processing MBID matching #15635

Merged
merged 1 commit into from Mar 1, 2019

Conversation

Projects
None yet
2 participants
@DaveTBlake
Copy link
Member

commented Feb 28, 2019

Fix bug in album artist name and Musicbrainz id tag matching process for collaboration albums e.g. those with more than one album artist

Issue occurred when album has

  • More than one album artist but Kodi can not separate the ALBUMARTIST tag into individual artists. For example ID3 v2.3 format tags (single frame) used with non-standard separator that has not been added to advancedsettings.xml e.g. ALBUMARTIST = "Simonetti - Pignatelli - Morante".
  • MUSICBRAINZ ALBUM ARTIST ID tag provides mbid values all of the artists
  • Values for ALBUMARTISTS tag is not provided (sadly not default Picard behaviour, but can do so)
  • ARTISTS and MUSICBRAINZ ARTIST ID tags do provide matching name and mbid values, and they are the same artisits as the album artists, but the artists are credited in a different order e.g. "Simonetti / Morante / Pignatelli"

An example release with this tag combination is https://musicbrainz.org/release/1ad13756-05e9-4ab4-b6cc-b9ce782431f5 when tagged as ID3 v2.3 format by Picard default settings. Kindly reported by a user https://forum.kodi.tv/showthread.php?tid=341341. But it is an uncommon combination hence the processing flaw has only just shown up.

When unable to match up the album artist names and mbids, Kodi attempts to use the (song) artist names and mbid values as a fallback to sort out what individual album artists have been provided. The fix is simply to use the correct vector index when doing this.

Fix album artist name and Musicbrainz id tag matching fallback proces…
…sing when ALBUMARTISTS tag not provided

@DaveTBlake DaveTBlake added this to the Leia 18.2-rc1 milestone Feb 28, 2019

@MartijnKaijser MartijnKaijser merged commit dcf935b into xbmc:master Mar 1, 2019

1 check passed

default You're awesome. Have a cookie
Details

@DaveTBlake DaveTBlake deleted the DaveTBlake:albumartistMBIDmatch branch Mar 1, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.