Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Android] send BUFFER_FLAG_END_OF_STREAM to MediaCodec if EOF was detected #15636

Merged
merged 1 commit into from Feb 28, 2019

Conversation

Projects
None yet
2 participants
@peak3d
Copy link
Contributor

commented Feb 28, 2019

Description

Streams with still frames could be stated as EOF instead the normal case RUNNING in MediaCodec decoder. We have to send the BUFFER_FLAG_END_OF_STREAM in this situation, too.

Extends: #15622

Motivation and Context

System freeze playing mpeg2 DVD so on nvidia shield

How Has This Been Tested?

  • Play DVD iso with still / very small first video sequence -> mpeg2 decoder freeze

Types of change

  • Bug fix (non-breaking change which fixes an issue)
  • Clean up (non-breaking change which removes non-working, unmaintained functionality)
  • Improvement (non-breaking change which improves existing functionality)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that will cause existing functionality to change)
  • Cosmetic change (non-breaking change that doesn't touch code)
  • None of the above (please explain below)

@peak3d peak3d added this to the Leia 18.2-rc1 milestone Feb 28, 2019

@peak3d peak3d changed the title [Android] send BUFFER_EOF to MediaCdec if EOF was detected [Android] send BUFFER_EOF to MediaCodec if EOF was detected Feb 28, 2019

@peak3d peak3d changed the title [Android] send BUFFER_EOF to MediaCodec if EOF was detected [Android] send BUFFER_FLAG_EOF to MediaCodec if EOF was detected Feb 28, 2019

@peak3d peak3d changed the title [Android] send BUFFER_FLAG_EOF to MediaCodec if EOF was detected [Android] send BUFFER_FLAG_END_OF_STREAM to MediaCodec if EOF was detected Feb 28, 2019

@MartijnKaijser MartijnKaijser merged commit 9310b1d into xbmc:master Feb 28, 2019

1 check was pending

default Found some time, building it now.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.