Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Android] generate keypress for mediasession actions #15654

Merged
merged 1 commit into from Mar 3, 2019

Conversation

Projects
None yet
2 participants
@peak3d
Copy link
Contributor

commented Mar 2, 2019

Description

If kodi has the focus, create normal keypress instead performing the mediasession actions

Motivation and Context

fixes #15003
fixes #15189

How Has This Been Tested?

Small test on AFTV 4K

  • Press FFD and read log if it is handles as normal Keypress

Types of change

  • Bug fix (non-breaking change which fixes an issue)
  • Clean up (non-breaking change which removes non-working, unmaintained functionality)
  • Improvement (non-breaking change which improves existing functionality)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that will cause existing functionality to change)
  • Cosmetic change (non-breaking change that doesn't touch code)
  • None of the above (please explain below)

@peak3d peak3d force-pushed the peak3d:mediasession branch from 11f4cfe to 3b261db Mar 3, 2019

@peak3d peak3d removed the Don't merge label Mar 3, 2019

@peak3d peak3d changed the title [Android] FF to keypress [Android] generate keypress for mediasession actions Mar 3, 2019

@peak3d peak3d added this to the Leia 18.2-rc1 milestone Mar 3, 2019

@peak3d

This comment has been minimized.

Copy link
Contributor Author

commented Mar 3, 2019

OSX unrelated

@peak3d peak3d merged commit 847f1e8 into xbmc:master Mar 3, 2019

1 check failed

default Sorry, building this PR failed. Please check the logs for the errors.
Details

@peak3d peak3d deleted the peak3d:mediasession branch Mar 3, 2019

@Rechi Rechi added the v18 Leia label Mar 3, 2019

@peak3d peak3d referenced this pull request Mar 5, 2019

Merged

[Android] implement MediaSession::onMediaButtonEvent #15675

1 of 7 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.