Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Android] Prevent HDMI_AUDIO_PLUG intent on TV #15661

Merged
merged 1 commit into from Mar 4, 2019

Conversation

Projects
None yet
3 participants
@peak3d
Copy link
Contributor

commented Mar 3, 2019

Description

We use the HDMI_AUDIO_PLUG intent for pausing video playback during resolution / refreshrate switching.
This works well on kodi boxes which are HDMI source, but is not correct if kodi runs on TV and connected HDMI input (like AVR) changes. In that case kodi went into playback pause even android system manages audio playback internally right.

Motivation and Context

@da-anda 's request in slack (turn AVR off == Kodi stream stall

fixes #15650

How Has This Been Tested?

I only tested, if kodi still works on TV box (ro.hdmi.device_type = 4)

Types of change

  • Bug fix (non-breaking change which fixes an issue)
  • Clean up (non-breaking change which removes non-working, unmaintained functionality)
  • Improvement (non-breaking change which improves existing functionality)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that will cause existing functionality to change)
  • Cosmetic change (non-breaking change that doesn't touch code)
  • None of the above (please explain below)

@peak3d peak3d force-pushed the peak3d:audioplug branch from af3a762 to ddff5e0 Mar 3, 2019

@da-anda

This comment has been minimized.

Copy link
Member

commented Mar 3, 2019

related bug report #15650
thanks, will trigger a test build and give feedback.

edit: mind adding something like fixes #15650 to the commit? Should hopefully auto-close the related issue once merged.

@peak3d

This comment has been minimized.

Copy link
Contributor Author

commented Mar 4, 2019

Test builds are automatically build in this pr, no need to trigger by yourself

@da-anda

This comment has been minimized.

Copy link
Member

commented Mar 4, 2019

Test builds are automatically build in this pr, no need to trigger by yourself

It does a compile test, but the results are never uploaded to our mirrors.

So I tested the testbuild I triggered and it seems to work like a charm. Thanks for fixing this.

@Rechi

This comment has been minimized.

Copy link
Member

commented Mar 4, 2019

It's not uploaded to the mirrors as the traffic for syncing with around 50 mirrors for a single person downloading it is useless.
status check > jenkins > your android architecture > download apk.

@peak3d peak3d merged commit caa105b into xbmc:master Mar 4, 2019

1 check passed

default You're awesome. Have a cookie
Details

@peak3d peak3d deleted the peak3d:audioplug branch Mar 4, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.