Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PVR] Speedup close of Guide window. #15683

Merged
merged 1 commit into from Mar 7, 2019

Conversation

Projects
None yet
2 participants
@ksooo
Copy link
Member

commented Mar 6, 2019

Small code change with noticeable performance improvement effect when closing Guide windows containing lots of epg data. No need to create a deep copy of tens of thousands of items. ;-)

@Jalle19 good to go?

@ksooo ksooo added this to the Leia 18.2-rc1 milestone Mar 6, 2019

@ksooo ksooo requested a review from Jalle19 Mar 6, 2019

@Jalle19
Copy link
Member

left a comment

The comment still talks about a copy

@ksooo

This comment has been minimized.

Copy link
Member Author

commented Mar 6, 2019

Yeah, just noticed this myself. I will change that.

@Jalle19

This comment has been minimized.

Copy link
Member

commented Mar 6, 2019

Are you sure this doesn't have any odd side effects, e.g. the original items being freed and the whole thing blowing up? Maybe this newTimeline thing is not needed at all?

@ksooo

This comment has been minimized.

Copy link
Member Author

commented Mar 6, 2019

Maybe this newTimeline thing is not needed at all?

This dramatically speeds up opening the guide window. Without this, the whole guide data model needs to be recalculated on re-opening, which can take several seconds and the user looks at an empty non-responding window, then.

@ksooo

This comment has been minimized.

Copy link
Member Author

commented Mar 6, 2019

Are you sure this doesn't have any odd side effects, e.g. the original items being freed and the whole thing blowing up?

I'm pretty sure it does not blow up as nowadayws everything is shared pointers.

@ksooo ksooo merged commit 83fb1a3 into xbmc:master Mar 7, 2019

1 check passed

default You're awesome. Have a cookie
Details

@ksooo ksooo deleted the ksooo:pvr-speedup-epg-window-close branch Mar 7, 2019

@Jalle19

This comment has been minimized.

Copy link
Member

commented Mar 7, 2019

Cool

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.