Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PVR] Fixes for broken timer handling #15689

Merged
merged 3 commits into from Mar 7, 2019

Conversation

Projects
None yet
2 participants
@phunkyfish
Copy link
Contributor

commented Mar 6, 2019

Description

  • Don't display Activate/Deactivate in timer context menu if timer state is PVR_TIMER_STATE_ERROR
  • Don't display enabled toggle in timer settings dialog if timer state is PVR_TIMER_STATE_ERROR
  • Don't include timer in active or recording lists if timer state is PVR_TIMER_STATE_ERROR

Motivation and Context

Deactivating doesn't make sense when a timer is in this state.

Fixes #15682

How Has This Been Tested?

Built kodi, on OSX with just pvr.vuplus to test.

Screenshots (if appropriate):

Types of change

  • [ x] Bug fix (non-breaking change which fixes an issue)
  • Clean up (non-breaking change which removes non-working, unmaintained functionality)
  • Improvement (non-breaking change which improves existing functionality)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that will cause existing functionality to change)
  • Cosmetic change (non-breaking change that doesn't touch code)
  • None of the above (please explain below)

Checklist:

  • [ x] My code follows the Code Guidelines of this project
  • My change requires a change to the documentation, either Doxygen or wiki
  • I have updated the documentation accordingly
  • [x ] I have read the Contributing document
  • I have added tests to cover my change
  • All new and existing tests passed

@phunkyfish phunkyfish changed the title Don't display Activate/Deactivate in timer context menu if timer stat… [PVR] Don't display Activate/Deactivate in timer context menu if timer stat… Mar 6, 2019

@phunkyfish phunkyfish force-pushed the phunkyfish:timer-state-error-menu branch from 67c3162 to 32087f1 Mar 6, 2019

@ksooo

This comment has been minimized.

Copy link
Member

commented Mar 7, 2019

You should change title and description of this PR to match the content. We extended the original scope more to "Fixes for broken timer handling."

@phunkyfish phunkyfish changed the title [PVR] Don't display Activate/Deactivate in timer context menu if timer stat… [PVR] Fixes for broken timer handling Mar 7, 2019

@phunkyfish

This comment has been minimized.

Copy link
Contributor Author

commented Mar 7, 2019

Done ;)

@ksooo

ksooo approved these changes Mar 7, 2019

Copy link
Member

left a comment

Code changes look good to me. Cannot runtime-test myself, thus I do assume you did.

@ksooo ksooo added this to the Leia 18.2-rc1 milestone Mar 7, 2019

@phunkyfish

This comment has been minimized.

Copy link
Contributor Author

commented Mar 7, 2019

Yes, I have tested this.

Timer in an error state when it would be recording now.
Timer in an error state when it should be recording next
Timer in an error state that should be completed if not an error
Timer in an error state which is not now or next

@ksooo

This comment has been minimized.

Copy link
Member

commented Mar 7, 2019

Very nice. Thanks for your first contribution to the Kodi PVR component. :-)

@ksooo ksooo merged commit 7efb8a6 into xbmc:master Mar 7, 2019

1 check passed

default You're awesome. Have a cookie
Details
@phunkyfish

This comment has been minimized.

Copy link
Contributor Author

commented Mar 7, 2019

Thanks, it’s was fun and thanks for the guidance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.