Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Music]Fix listing scraped artist art when choose art on Artist Info dialog #15701

Merged
merged 1 commit into from Mar 9, 2019

Conversation

Projects
None yet
2 participants
@DaveTBlake
Copy link
Member

commented Mar 8, 2019

Fix issue that stopped the available artist art (previously scraped remote sites as URLs ) from being shown when choosing artist art on the artist info dialog. Reported as issue #15699.

Thanks for spotting this @ronie, can you test and confirm this fixes issue.

It is a bug that crept in with #15277, skiping fetching the unwanted discography also accidentally skipped parsing the art URLs. Also ensure discography is imported and exported for artist, something that could also have been impacted by the previous change.

GetArtist - always fetch scraped art URLs from dataset.
Ensure discography is imported and exported for artist.
@ronie

This comment has been minimized.

Copy link
Member

commented Mar 8, 2019

tested and confirm this fixes the issue.
cheers!

@DaveTBlake DaveTBlake merged commit 72b513c into xbmc:master Mar 9, 2019

1 check passed

default You're awesome. Have a cookie
Details

@DaveTBlake DaveTBlake deleted the DaveTBlake:ArtistArtURLFix branch Mar 9, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.