Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PVR] Speedup first open of Guide window. #15702

Merged
merged 1 commit into from Mar 9, 2019

Conversation

Projects
None yet
2 participants
@ksooo
Copy link
Member

commented Mar 8, 2019

Obtaining tens of thousands of epg events at once on very first open of Guide window may take some time and the user sees a "blank" Guide window meanwhile. 20K of events take 1.5 secs on my Android Shield TV and we have users with far more data.

This PR will return all channels on first open, but without epg data. This takes almost zero time. The latter will be fetched asynchronously as soon as initial empty grid is ready. User will see all channels immediately. Channels will filling with EPG data asynchronously, then. Works well, nice user experience. ;-)

@Jalle19 good to go?

@ksooo ksooo added this to the Leia 18.2-rc1 milestone Mar 8, 2019

@ksooo ksooo requested a review from Jalle19 Mar 8, 2019

@ksooo ksooo force-pushed the ksooo:pvr-guide-window-open branch from a0ecd41 to f056690 Mar 8, 2019

@Jalle19

Jalle19 approved these changes Mar 9, 2019

Show resolved Hide resolved xbmc/pvr/windows/GUIWindowPVRGuide.cpp

@ksooo ksooo force-pushed the ksooo:pvr-guide-window-open branch from f056690 to 6c187f8 Mar 9, 2019

@ksooo ksooo merged commit 3597400 into xbmc:master Mar 9, 2019

1 check was pending

default Found some time, building it now.
Details

@ksooo ksooo deleted the ksooo:pvr-guide-window-open branch Mar 9, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.