Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PVR] Fix 'any channel' timer rules children not displayed. #15714

Merged
merged 1 commit into from Mar 11, 2019

Conversation

Projects
None yet
3 participants
@ksooo
Copy link
Member

commented Mar 10, 2019

Fixes #15710

@Jalle19 Got some time for a short review? Using Window Manager to determine the context for the status string is not the nicest solution, but without new GUI labels the only way (I found).

@phunkyfish could you runtime-test? I did and it seems to work well.

@ksooo ksooo added this to the Leia 18.2-rc1 milestone Mar 10, 2019

@ksooo ksooo requested a review from Jalle19 Mar 10, 2019

@phunkyfish

This comment has been minimized.

Copy link
Contributor

commented Mar 10, 2019

Ya, will runtime Test

@ksooo ksooo force-pushed the ksooo:pvr-fix-anychannel-timerrules branch from 62d859e to 70375ac Mar 10, 2019

@phunkyfish

This comment has been minimized.

Copy link
Contributor

commented Mar 10, 2019

I have not been able to see the timers under the timer rule. This is most likely my addon code, need a bit more time to figure out what’s happening.

@ksooo

This comment has been minimized.

Copy link
Member Author

commented Mar 11, 2019

Works with pvr.hts.

@phunkyfish

This comment has been minimized.

Copy link
Contributor

commented Mar 11, 2019

@ksooo

This comment has been minimized.

Copy link
Member Author

commented Mar 11, 2019

So, good to go in?

@phunkyfish

This comment has been minimized.

Copy link
Contributor

commented Mar 11, 2019

Correct, thanks for the quick turnaround.

@ksooo ksooo merged commit ac9206b into xbmc:master Mar 11, 2019

1 check passed

default You're awesome. Have a cookie
Details

@ksooo ksooo deleted the ksooo:pvr-fix-anychannel-timerrules branch Mar 11, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.