Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Android] Don't signal END_OF_STREAM if dropping packets #15719

Merged
merged 1 commit into from Mar 11, 2019

Conversation

Projects
None yet
2 participants
@peak3d
Copy link
Contributor

commented Mar 10, 2019

Description

When seeking for resume point after seek we currently flush too often what leads to playback start on non-I-Frame. This not only looks ugly, it also kills some h/w decoder.

Motivation and Context

Conversation with NVIDIA regarding seek issues.

How Has This Been Tested?

Most visible using webm VP9 streams because we don't provide bitstream parser for this.
e.g.: https://mango.blender.org/download/ the 1080p webm stream (VP8)

  • start stream
  • seek to 5 minutes
  • stop stream
  • resume

Types of change

  • Bug fix (non-breaking change which fixes an issue)
  • Clean up (non-breaking change which removes non-working, unmaintained functionality)
  • Improvement (non-breaking change which improves existing functionality)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that will cause existing functionality to change)
  • Cosmetic change (non-breaking change that doesn't touch code)
  • None of the above (please explain below)

@peak3d peak3d added this to the Leia 18.2-rc1 milestone Mar 10, 2019

@peak3d peak3d merged commit 83c280a into xbmc:master Mar 11, 2019

1 check passed

default You're awesome. Have a cookie
Details

@peak3d peak3d deleted the peak3d:drop branch Mar 11, 2019

@iz8mbw

This comment has been minimized.

Copy link

commented Mar 11, 2019

Thanks @peak3d
Tested this PR on Nvidia Shield and now I can skip between chapters without problems and without freeze. Previously with some mvk when I skipped between chapters video freezed.
Thank you as usual!!!!

@iz8mbw

This comment has been minimized.

Copy link

commented Mar 11, 2019

@peak3d
This your PR does solve also this problem:
#14718 ?

@peak3d peak3d referenced this pull request Mar 13, 2019

Merged

[Android] rework intermediate stream start / flush #15622

1 of 7 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.