Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle signals by setting atomic flag instead of pop-up thread #15730

Merged
merged 1 commit into from Mar 18, 2019

Conversation

Projects
None yet
3 participants
@pkerling
Copy link
Member

commented Mar 12, 2019

Thread creation in signal handlers is not safe. One of the few safe
things to do is set an atomic (lock-free) flag, so do that instead.

Fixes #15677

[posix] Handle signals by setting atomic flag instead of pop-up thread
Thread creation in signal handlers is not safe. One of the few safe
things to do is set an atomic (lock-free) flag, so do that instead.

Fixes #15677
@Memphiz

This comment has been minimized.

Copy link
Member

commented Mar 12, 2019

Nice approach imo. Which signal should I use to test? Kill?

@Memphiz Memphiz closed this Mar 12, 2019

@Memphiz Memphiz reopened this Mar 12, 2019

@pkerling

This comment has been minimized.

Copy link
Member Author

commented Mar 12, 2019

@Memphiz

This comment has been minimized.

Copy link
Member

commented Mar 13, 2019

@pkerling it works on Darwin here.

@pkerling pkerling merged commit c7bac97 into xbmc:master Mar 18, 2019

1 check passed

default You're awesome. Have a cookie
Details

@pkerling pkerling deleted the pkerling:fix-posix-signal branch Mar 18, 2019

@Rechi Rechi added this to the Leia 18.2-rc1 milestone Mar 18, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.