Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Android] Yet another refreshrate switch enhancement #15732

Merged
merged 1 commit into from Mar 12, 2019

Conversation

Projects
None yet
2 participants
@peak3d
Copy link
Contributor

commented Mar 12, 2019

Description

New logic:

  • SetNativeResoluiton (==modechange) called
  • Trigger android mode change (using window layout param)
  • Wait for onDisplayChange callback invocation (max. 5 seconds)
  • Trigger OnLostDisplay (max. runtime 2 seconds)
    If during these 2 seconds a HDMI_AUDIOPLUG intent arrives, stop the timer, wait for HDMI on state.

Motivation and Context

1.) Improve mode switch by not resetting Audio before android's new mode is triggered
2.) Allow mode changes on devices which don't switch HDMI on some modes (e.g. AFTV 2018, 59.94 -> 60 changes the mode, but does not lead to HDMI / TV switch)

How Has This Been Tested?

AFTV 2017 / 2018 / Wetek HUB / ShieldTV. play various streams which force a mode switch.

Types of change

  • Bug fix (non-breaking change which fixes an issue)
  • Clean up (non-breaking change which removes non-working, unmaintained functionality)
  • Improvement (non-breaking change which improves existing functionality)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that will cause existing functionality to change)
  • Cosmetic change (non-breaking change that doesn't touch code)
  • None of the above (please explain below)
@@ -1409,6 +1394,8 @@ void CXBMCApp::onDisplayAdded(int displayId)

void CXBMCApp::onDisplayChanged(int displayId)
{
if (g_application.IsInitialized())
CLog::Log(LOGDEBUG, "%s", __PRETTY_FUNCTION__);

This comment has been minimized.

Copy link
@AlwinEsch

AlwinEsch Mar 12, 2019

Member

Is this not a bit less for a log call?

This comment has been minimized.

Copy link
@peak3d

peak3d Mar 12, 2019

Author Contributor

Its a debug log

@peak3d peak3d force-pushed the peak3d:hdmi branch from 1ec2cc1 to 53549dc Mar 12, 2019

@peak3d peak3d merged commit adf1da5 into xbmc:master Mar 12, 2019

1 check passed

default You're awesome. Have a cookie
Details

@peak3d peak3d deleted the peak3d:hdmi branch Mar 12, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.