Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PVR] Only trigger CPVRUpdateAddonsJob if the AddonEvent is a PVR client #15753

Merged
merged 1 commit into from Mar 15, 2019

Conversation

Projects
None yet
2 participants
@enen92
Copy link
Member

commented Mar 15, 2019

Description

Trigger only the PVRUpdateAddons job if the resulting event is in fact triggered by a PVR client event (addon: Enabled, Disabled, UnInstalled, ReInstalled).

Motivation and Context

Found while debugging trough other issues.

How Has This Been Tested?

Installed a video addon -> check the event was not triggered
Install pvr demo client -> check the event is triggered

Types of change

  • Bug fix (non-breaking change which fixes an issue)
  • Clean up (non-breaking change which removes non-working, unmaintained functionality)
  • Improvement (non-breaking change which improves existing functionality)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that will cause existing functionality to change)
  • Cosmetic change (non-breaking change that doesn't touch code)
  • None of the above (please explain below)

@enen92 enen92 added this to the Leia 18.2-rc1 milestone Mar 15, 2019

@enen92 enen92 requested a review from ksooo Mar 15, 2019

@ksooo

ksooo approved these changes Mar 15, 2019

Copy link
Member

left a comment

Looks good to me. Thanks.

@enen92 enen92 merged commit 32d3bbe into xbmc:master Mar 15, 2019

1 check passed

default You're awesome. Have a cookie
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.