Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GUIControllerWindow] Correctly subscribe to RepositoryUpdated events #15755

Merged
merged 1 commit into from Mar 16, 2019

Conversation

Projects
None yet
2 participants
@enen92
Copy link
Member

commented Mar 15, 2019

Description

The window has methods to react to RepositoryUpdated events but their callback is never triggered since the window does not subscribe them on init/deinit.

Motivation and Context

Found while working on #15754

How Has This Been Tested?

Compile and runtime test

Types of change

  • Bug fix (non-breaking change which fixes an issue)
  • Clean up (non-breaking change which removes non-working, unmaintained functionality)
  • Improvement (non-breaking change which improves existing functionality)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that will cause existing functionality to change)
  • Cosmetic change (non-breaking change that doesn't touch code)
  • None of the above (please explain below)

@enen92 enen92 merged commit 5326477 into xbmc:master Mar 16, 2019

1 check passed

default You're awesome. Have a cookie
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.