[cec] libCEC 2.0.0 support #1576

Merged
merged 6 commits into from Oct 10, 2012

Projects

None yet

1 participant

@opdenkamp
Member

Bit late to the party, but there was a little hold up.
This bumps libCEC to 2.0.0. This is a major version bump, as deprecated methods (that XBMC was no longer using anymore anyway) were removed, and there were some minor fixups in the headers to fix plain C compilation. The changes for XBMC are only minor, see b45b9a4, but it's still a breaking API change.

Full changelog can be found here: https://github.com/Pulse-Eight/libcec/blob/release/ChangeLog

Then some cleanups of the code:

  • commits 3f48f5b477f352ce53b798db4e3f275be21adca4 and 2dd4bf3fae24f7b23c5d188ef1dc93de52815fcf simplify the peripheral settings, by replacing the strings with logical addresses by enum values. The old settings can still be defined by a user in the .xml file for the adapter (wake_devices_advanced + standby_devices_advanced).
  • rest are minor cleanups, and a hidden setting to change the new double tap prevention timeout in libCEC.

I know it's late, but I'd like to see this included in Frodo, as this is a breaking API change, even though it's minor, and it's needed to fix C compilation. It also cleans up things that were used during early development and that were still floating around in the headers, including some very nasty ifdefs because of accidental breakage cause the official Windows and Linux Eden builds were using different API versions, and users who just upgraded libcec.dll/.so ran into crashes.

Deps will be uploaded shortly (unless someone beats me)

@opdenkamp
Member

@jmarshallnz updated. i've put the updated translation in a separate commit: 415d11c

@opdenkamp
Member

deps uploaded

@opdenkamp opdenkamp was assigned Oct 10, 2012
@opdenkamp
Member

not seeing any objections, so i'm pressing the button if i don't see any within the next hour or so :)

@opdenkamp opdenkamp merged commit 922dfc4 into xbmc:master Oct 10, 2012
@opdenkamp
Member

@amejia1 ping, sorry forgot, ppa needs it's copy too or it won't include cec support after this and i can't upload things there myself. could you grab it from packages.pulse-eight.net or pulse-eight's ppa please.

all the other deps are on the mirrors

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment