Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move libcurl symbols out of namespace #15778

Merged
merged 1 commit into from Mar 25, 2019

Conversation

@pkerling
Copy link
Member

commented Mar 20, 2019

Putting includes (that can in turn include all sorts of other stuff)
into namespaces is not really maintainable and finally broke the build
in Linux 5.1-rc1. Of course it was a good idea to not clutter the global
namespaces, but unfortunately it did not turn out to be possible with C
libraries.

See https://sourceware.org/ml/libc-help/2019-03/msg00014.html

Fixes #15775

[curl] Move libcurl symbols out of namespace
Putting includes (that can in turn include all sorts of other stuff)
into namespaces is not really maintainable and finally broke the build
in Linux 5.1-rc1. Of course it was a good idea to not clutter the global
namespaces, but unfortunately it did not turn out to be possible with C
libraries.

See https://sourceware.org/ml/libc-help/2019-03/msg00014.html

Fixes #15775
@wsnipex

This comment has been minimized.

Copy link
Member

commented Mar 23, 2019

should we hold off with this for v19?

@Paxxi

Paxxi approved these changes Mar 24, 2019

Copy link
Member

left a comment

looks good to me

@pkerling

This comment has been minimized.

Copy link
Member Author

commented Mar 24, 2019

@wsnipex I think we should be good if we have it in test builds for a week or so?

@MilhouseVH Are you by any chance already including this?

@MilhouseVH

This comment has been minimized.

Copy link
Contributor

commented Mar 24, 2019

@MilhouseVH Are you by any chance already including this?

Yes it's been in my test builds since #0320, so for the last 4 nightly builds, and no issues so far.

@pkerling

This comment has been minimized.

Copy link
Member Author

commented Mar 25, 2019

IMO good for v18 so people can still compile it on the new Linux version. @wsnipex fine with merging?

@wsnipex

This comment has been minimized.

Copy link
Member

commented Mar 25, 2019

yes, I'm ok with it

@pkerling pkerling merged commit 4e60402 into xbmc:master Mar 25, 2019

1 check passed

default You're awesome. Have a cookie
Details

@pkerling pkerling deleted the pkerling:linux-5.1-rc1 branch Mar 25, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.