GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
Already on GitHub? Sign in to your account
This fixes sometime incorrect metadata after changing track, and also reduces the number of lookups.
Could we get
if (strcmp(message, "OnPlay") == 0)
here instead. That "!" confused me for a second as it kinda reads like "if not string compare".
EDIT: Same on the ones further down.
You might wanna cast the return value of asInteger() to (int) because it returns int64_t which doesn't match %d (same further down).
Apart from the two things I mentioned and @jmarshallnz's comment it looks good.
[UPnP] fix: use Announcement manager to update metadata and volume st…
rather than every second in Application::ProcessSlow. Also handle play/pause
@elupus happy with this going in?
Yes if the other comments have been resolved.
Merge pull request #1578 from alcoheca/renderer-updates
[UPnP] fix: use Announcement manager to update UPnPRenderer state vars