Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] installing binary addons from zip (and repo) #15780

merged 1 commit into from Mar 20, 2019


None yet
2 participants
Copy link

commented Mar 20, 2019


This fixes the installing process of binray addons from zip files (also including installing from a repository).

Motivation and Context

Screensavers and visualisation addons weren't usable after the installation from zip. Only a black screen was shown and CBinaryAddonManager::__FUNCTION__: Requested addon '<ADDON-ID>' unknown as binary was logged.
One had to restart Kodi to get it working.
Edit: same for vfs addons, but for those CBinaryAddonManager::__FUNCTION__: Requested addon '<ADDON-ID>' unknown as binary wasn't logged

How Has This Been Tested?

installed a screensaver and visualisation from zip and tested it without restarting Kodi

Types of change

  • Bug fix (non-breaking change which fixes an issue)
  • Clean up (non-breaking change which removes non-working, unmaintained functionality)
  • Improvement (non-breaking change which improves existing functionality)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that will cause existing functionality to change)
  • Cosmetic change (non-breaking change that doesn't touch code)
  • None of the above (please explain below)


  • My code follows the Code Guidelines of this project
  • My change requires a change to the documentation, either Doxygen or wiki
  • I have updated the documentation accordingly
  • I have read the Contributing document
  • I have added tests to cover my change
  • All new and existing tests passed

@Rechi Rechi added this to the Leia 18.2-rc1 milestone Mar 20, 2019

@Rechi Rechi requested a review from AlwinEsch Mar 20, 2019

Copy link

left a comment

From my side OK, in case of normal enable the InstalledChangeEvent() should do nothing and does not affect something.

Becomes cleaned up in future (Kick of this CBinaryAddonManager) but for Leia is the fix a must be.

@Rechi Rechi merged commit ba702ac into xbmc:master Mar 20, 2019

1 check passed

default You're awesome. Have a cookie

@Rechi Rechi deleted the Rechi:fix/installBinaryAddons branch Mar 20, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.