Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GL: Don't use SM_TEXTURE_LIM for GLSL < 1.5 #15783

Merged
merged 1 commit into from Mar 26, 2019

Conversation

Projects
None yet
6 participants
@kszaq
Copy link
Contributor

commented Mar 20, 2019

Description

SM_TEXTURE_LIM is not available for GLSL < 1.5, we should use SM_TEXTURE instead.

Motivation and Context

Fixes #15723

How Has This Been Tested?

Both users who reported the issue confirmed a fix.

Screenshots (if appropriate):

Types of change

  • Bug fix (non-breaking change which fixes an issue)
  • Clean up (non-breaking change which removes non-working, unmaintained functionality)
  • Improvement (non-breaking change which improves existing functionality)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that will cause existing functionality to change)
  • Cosmetic change (non-breaking change that doesn't touch code)
  • None of the above (please explain below)

Checklist:

  • My code follows the Code Guidelines of this project
  • My change requires a change to the documentation, either Doxygen or wiki
  • I have updated the documentation accordingly
  • I have read the Contributing document
  • I have added tests to cover my change
  • All new and existing tests passed
GL: Don't use SM_TEXTURE_LIM for GLSL < 1.5
SM_TEXTURE_LIM is not available for GLSL < 1.5, we should use SM_TEXTURE instead.

Fixes #15723

@kszaq kszaq force-pushed the kszaq:patch-1 branch from 720bee4 to 2e2e841 Mar 20, 2019

@kszaq kszaq marked this pull request as ready for review Mar 20, 2019

@kszaq kszaq referenced this pull request Mar 20, 2019

Closed

Kodi 18.1 do not display DVB subtitles correctly on linux #15723

1 of 7 tasks complete
@kszaq

This comment has been minimized.

Copy link
Contributor Author

commented Mar 20, 2019

Issue fixed confirmed by user who reported.

@FernetMenta Thank you for providing a solution. Can you please review?

@FernetMenta

This comment has been minimized.

Copy link
Member

commented Mar 21, 2019

looks good to me

@kszaq

This comment has been minimized.

Copy link
Contributor Author

commented Mar 26, 2019

Can Jenkins try to build this? Last time the build failed before it even started.

@fritsch

This comment has been minimized.

Copy link
Member

commented Mar 26, 2019

jenkins build and merge

@jenkins4kodi jenkins4kodi merged commit 2bc5c9b into xbmc:master Mar 26, 2019

1 check was pending

default Found some time, building it now.
Details

@kszaq kszaq deleted the kszaq:patch-1 branch Mar 26, 2019

@Rechi Rechi added the v18 Leia label Mar 26, 2019

@Rechi Rechi added this to the Leia 18.2-rc1 milestone Mar 26, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.