Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix]Export all art types for albums and artists, not just thumb and fanart #15792

Merged
merged 1 commit into from Mar 25, 2019

Conversation

Projects
None yet
2 participants
@DaveTBlake
Copy link
Member

commented Mar 21, 2019

Music export was missing the extended art types that the music library now supports.

@KarellenX thanks for reporting this and politely nagging me to fix it.

@KarellenX

This comment has been minimized.

Copy link

commented Mar 22, 2019

Extended artwork was not exported as expected with this build.

Obviously a fresh install and a small subset of my library consisting of 12 albums with 38 Artists according to the exported folders...

  1. Scanned songs into library
  2. Ran Query for both Albums and Artists after scan
  3. Went and made a coffee, came back and ran the Export.
  4. Artist folders were created and populated with nfo, fanart and thumb (I thought we changed that to folder.jpg). There was no Extended artwork.
  5. Went back to Artist listing and selected Choose Art for a few artists that I knew should have had extended art. The artwork loaded in the Choose Art screen.
  6. Ran the export again and for those artists that I checked the Choose Art screen, extended artwork was exported. No other artist had extended artwork exported.

The above is also true for Albums.

Also, if there is no artwork available for an artwork type, it still displays the thumb.jpg image in the selection. Is this expected?

@DaveTBlake

This comment has been minimized.

Copy link
Member Author

commented Mar 22, 2019

@KarellenX thanks for testing, unfortuantely there were problems with the test build not being this version of the PR. I made mistakes in trying to combine PRs into one build, so much for saving test effort! I'll ping when a new test build is on the mirrors.

Artist folders were created and populated with nfo, fanart and thumb (I thought we changed that to folder.jpg)

Good point about folder.jpg not thumb - I had forgotten thumbs are the only type that filename does not match type. Will adjust that.

Also, if there is no artwork available for an artwork type, it still displays the thumb.jpg image in the selection. Is this expected?

Yes, that change is in a different PR.

@DaveTBlake DaveTBlake force-pushed the DaveTBlake:ExportArtFix branch from b85d995 to 32fdfed Mar 22, 2019

@DaveTBlake

This comment has been minimized.

Copy link
Member Author

commented Mar 22, 2019

@KarellenX

This comment has been minimized.

Copy link

commented Mar 23, 2019

I have tested the new build. It all works as expected for both Artists and Albums. All Artwork and NFO Files were exported correctly.

As a side note, only 35 Artist folders were created this time. Normally it is 38 with my test albums. The three missing Artists I found in All Roles>Producer

Also, maybe the fix is still to come, but the Choose Art screen still displays Thumbnail for Albums and Artists. Should this be changed to Folder for consistency?

@DaveTBlake

This comment has been minimized.

Copy link
Member Author

commented Mar 23, 2019

@KarellenX thanks for testing.

the Choose Art screen still displays Thumbnail for Albums and Artists. Should this be changed to Folder for consistency?

No plan for that to my knowledge.

@DaveTBlake DaveTBlake merged commit da3ca5b into xbmc:master Mar 25, 2019

1 check passed

default You're awesome. Have a cookie
Details

@DaveTBlake DaveTBlake deleted the DaveTBlake:ExportArtFix branch Mar 25, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.