Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[skins] addon settings - add help text #15795

Merged
merged 1 commit into from Mar 25, 2019

Conversation

Projects
None yet
6 participants
@ronie
Copy link
Member

commented Mar 21, 2019

since #12125 addons can now also add a help text for each setting.
our default skins where not updated to include this text though.

fixes #15793

screenshot000

@scott967

This comment has been minimized.

Copy link

commented Mar 22, 2019

Could the wiki entry for Skinning Manual para 16.1.3 DialogAddonSettings.xml be updated to show control ID 6 Textbox Setting Help?

@ronie

This comment has been minimized.

Copy link
Member Author

commented Mar 22, 2019

sure, go ahead

@MartijnKaijser

This comment has been minimized.

Copy link
Member

commented Mar 22, 2019

Anything that needs to be added in doxygen somewhere?
Maybe @DaVukovic knows?

@phunkyfish

This comment has been minimized.

Copy link
Contributor

commented Mar 22, 2019

Just tested this. The binary addons uses a different sized modal dialog so the text appears in the bottom left corner outside of the dialog in pvr.vuplus (did not test with other addon types):

Screen Shot 2019-03-22 at 08 17 42

@phunkyfish

This comment has been minimized.

Copy link
Contributor

commented Mar 22, 2019

I don't know why the dialog is a different size, I guess it could be larger to accommodate and be the consistent with the global settings dialog you used to test above. The positioning does conflict with the position of the settings level button in #15796

@ronie

This comment has been minimized.

Copy link
Member Author

commented Mar 22, 2019

thanx for testing @phunkyfish
i'll have another look at it.

@phunkyfish

This comment has been minimized.

Copy link
Contributor

commented Mar 22, 2019

Cool, happy to test again once you're ready.

@enen92

This comment has been minimized.

Copy link
Member

commented Mar 22, 2019

@MartijnKaijser this only applies to the new settings format afaik. Unfortunately we don't have any sort of documentation for them (either doxygen or wiki). Maybe a good candidate for a roadmap ticket.

@ronie ronie force-pushed the ronie:skins-addonhelp branch from cc22a78 to c4d1d93 Mar 23, 2019

@ronie

This comment has been minimized.

Copy link
Member Author

commented Mar 23, 2019

@phunkyfish please test both PR's individually. that should solve your issue.
(you can't test both at the same time, the second PR needs rebasing after the first one gets merged)

screenshot000

@phunkyfish

This comment has been minimized.

Copy link
Contributor

commented Mar 23, 2019

Strangely with the latest it appears different to your screen shot above:

Screen Shot 2019-03-23 at 21 16 28

It appears my dialog is higher on screen than yours.

@phunkyfish

This comment has been minimized.

Copy link
Contributor

commented Mar 23, 2019

Let me do a fresh kodi rebuild to make sure it's not something on my side.

@ronie

This comment has been minimized.

Copy link
Member Author

commented Mar 23, 2019

ah thx, i see what's going wrong.
nothing wrong at your end, it's something i gotta fix

@ronie ronie force-pushed the ronie:skins-addonhelp branch from c4d1d93 to 61d0132 Mar 23, 2019

@phunkyfish

This comment has been minimized.

Copy link
Contributor

commented Mar 24, 2019

Positioning spot on now @ronie

@ronie ronie merged commit 9718745 into xbmc:master Mar 25, 2019

@Rechi Rechi added this to the Leia 18.2-rc1 milestone Mar 25, 2019

@ronie ronie deleted the ronie:skins-addonhelp branch May 7, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.