Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include user config and available artwork in music "Choose art type" dialog #15805

Merged
merged 1 commit into from Apr 5, 2019

Conversation

Projects
None yet
3 participants
@rmrector
Copy link
Contributor

commented Mar 23, 2019

Description

Add more artwork types to the "Choose art type" dialog for the music library.

  1. Available but not assigned artwork types. Scrapers and NFO files can add more artwork than is assigned in the library, this includes these types in the dialog.
  2. User configuration. This includes artwork types currently configured in AdvancedSettings.xml.

Only music library, but a separate PR for the video library is incoming. It has a completely separate implementation and I need to add a database function. It also already has the "user config" part.

Motivation and Context

Don't hide artwork that is available. Don't make users enter any preferred artwork types twice (configuration and this dialog).

How Has This Been Tested?

manually.

Types of change

  • Improvement (non-breaking change which improves existing functionality)

@rmrector rmrector requested review from ronie and DaveTBlake Mar 23, 2019

@rmrector rmrector force-pushed the rmrector:fill-music-arttypes branch from e98fac5 to e3050f8 Mar 23, 2019

@DaveTBlake

This comment has been minimized.

Copy link
Member

commented Mar 24, 2019

See also discussion of #15747. Thanks for this @rmrector

@DaveTBlake

This comment has been minimized.

@MartijnKaijser MartijnKaijser added v19 Matrix and removed v18 Leia labels Mar 24, 2019

@rmrector rmrector force-pushed the rmrector:fill-music-arttypes branch from e3050f8 to bfb3000 Mar 25, 2019

Show resolved Hide resolved xbmc/music/MusicUtils.cpp Outdated
Show resolved Hide resolved xbmc/music/MusicUtils.cpp Outdated

@DaveTBlake DaveTBlake referenced this pull request Mar 25, 2019

Merged

Improve 'Choose Art' dialog #15747

0 of 6 tasks complete

@rmrector rmrector force-pushed the rmrector:fill-music-arttypes branch from bfb3000 to 7bb91d9 Mar 26, 2019

@DaveTBlake
Copy link
Member

left a comment

Thanks, all looks good and behaves as expected.
This improvement to manual art selection is low risk and could be usefully included in 18.2

@DaveTBlake

This comment has been minimized.

Copy link
Member

commented Mar 27, 2019

@MartijnKaijser I'm happy for improvement to music art management to go into 18.2, any reason you changed the label to v19? Otherwise can it be merged please

@DaveTBlake DaveTBlake added v18 Leia and removed v19 Matrix labels Apr 5, 2019

@DaveTBlake DaveTBlake added this to the Leia 18.2-rc1 milestone Apr 5, 2019

@DaveTBlake DaveTBlake merged commit 782b382 into xbmc:master Apr 5, 2019

1 check passed

default You're awesome. Have a cookie
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.