Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CThreads: Reacquire Lock after WaitForThreadExit has finished #15810

Merged
merged 1 commit into from Mar 25, 2019

Conversation

Projects
None yet
3 participants
@fritsch
Copy link
Member

commented Mar 25, 2019

Fixes: #15801 which also includes motivation and discussion for this fix.

Summary:
Make sure that the staticThread still relying on the criticalSection, does not get it removed under his ass, therefore reacquire the criticalsection after WaitForThreads has finished. Implementation uses SingleExit so that leave / lock is automatically done by the scope.

@fritsch fritsch added the Type: Fix label Mar 25, 2019

@fritsch fritsch requested a review from pkerling Mar 25, 2019

@pkerling

This comment has been minimized.

Copy link
Member

commented Mar 25, 2019

Code comment would be really appreciated or no one will know what this exit is about ;-)

@fritsch fritsch force-pushed the fritsch:cthread branch from 6d2fc7a to 628ddff Mar 25, 2019

@fritsch

This comment has been minimized.

Copy link
Member Author

commented Mar 25, 2019

Done - yes!

@pkerling pkerling added the v18 Leia label Mar 25, 2019

@pkerling pkerling added this to the Leia 18.2-rc1 milestone Mar 25, 2019

@pkerling

This comment has been minimized.

Copy link
Member

commented Mar 25, 2019

jenkins build and merge

@jenkins4kodi jenkins4kodi merged commit 429edd0 into xbmc:master Mar 25, 2019

1 check was pending

default Found some time, building it now.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.