Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

addon settings - inherit settings level #15813

Merged
merged 1 commit into from Mar 31, 2019

Conversation

Projects
None yet
4 participants
@ronie
Copy link
Member

commented Mar 25, 2019

Currently the settings level in the Addon Settings Dialog is harcoded to 'standard'.
The goal for v19 is to make it user-configurable by adding a settings level button to this dialog (#15796)

meanwhile, for v18, we should simply inherit the level that's been set on the main Kodi settings windows.

@ksooo @phunkyfish

@phunkyfish

This comment has been minimized.

Copy link
Contributor

commented Mar 25, 2019

Perfect, thanks @ronie

@phunkyfish

This comment has been minimized.

Copy link
Contributor

commented Mar 25, 2019

Tested and works as expected.

@phunkyfish

This comment has been minimized.

Copy link
Contributor

commented Mar 28, 2019

@ronie, can we expect this in 18.2?

@ronie

This comment has been minimized.

Copy link
Member Author

commented Mar 31, 2019

@phunkyfish yup, will merge it now.
thanx for testing the PR's!

@ronie ronie merged commit 295594d into xbmc:master Mar 31, 2019

1 check passed

default You're awesome. Have a cookie
Details
@phunkyfish

This comment has been minimized.

Copy link
Contributor

commented Apr 1, 2019

Any time, my pleasure. And thank you ;)

@Rechi Rechi added this to the Leia 18.2-rc1 milestone Apr 1, 2019

@ronie ronie deleted the ronie:addon-settingslevel.18 branch May 7, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.