Skip to content

Fix MySQL memory leak #1584

Merged
1 commit merged into from Oct 9, 2012

3 participants

@stintel
stintel commented Oct 9, 2012

Before commit 1f987e7, there were issues upgrading my music database to
the latest format (because of duplicate keys, which are solved by using
REPLACE instead of INSERT).

This pointed out a severe memory leak in
xbmc/dbwrappers/mysqldataset.cpp, which is confirmed by valgrind.

This is an attempt to fix the leak, and should solve #12459.

@Montellese Montellese was assigned Oct 9, 2012
@MartijnKaijser
Team Kodi member

@Montellese
Your territory

@Montellese
Team Kodi member

Not really, I don't even have a mysql setup so can't check if there's really a memory leak or not (but looking at the fix it might well be).

@ghost
ghost commented Oct 9, 2012

now squash the commits ;)

@stintel stintel Fix MySQL memory leak
Before commit 1f987e7, there were issues upgrading my music database to
the latest format (because of duplicate keys, which are solved by using
REPLACE instead of INSERT).

This pointed out a severe memory leak in
xbmc/dbwrappers/mysqldataset.cpp, which is confirmed by valgrind.

This is an attempt to fix the leak, and should solve #12459.
f102080
@ghost ghost merged commit 13d597c into xbmc:master Oct 9, 2012
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.