Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Amlogic fixes from community builds #15859

Merged
merged 6 commits into from Apr 13, 2019

Conversation

Projects
None yet
5 participants
@kszaq
Copy link
Contributor

commented Apr 3, 2019

Description, motivation and Context

This PR consists of a few commits that have been used in OSMC and community LibreELEC and CoreELEC builds for a long time that I don't consider "hacks" or "ugly workarounds".

The PR consists of:

  • fixing a crash when switching resolution in 3D mode
  • changing default resolution to 1080p since most TVs are at least 1080p nowadays
  • fix for HW decoding stop working for no reason
  • fix for very long playback PTS overflow
  • fix for a rare situation when fpsrate/fpsscale is 0 in mpeg2 frame rate tracking

I hope I got all commit authors correct.

I collected these in a single PR as all commits touch Amlogic-only code and have been in use for a long time, proven working.

How Has This Been Tested?

OSMC, CoreELEC and LibreELEC builds for Amlogic S905, S905X and S912 devices running for many months, confirming the issues were solved.

Types of change

  • Bug fix (non-breaking change which fixes an issue)
  • Clean up (non-breaking change which removes non-working, unmaintained functionality)
  • Improvement (non-breaking change which improves existing functionality)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that will cause existing functionality to change)
  • Cosmetic change (non-breaking change that doesn't touch code)
  • None of the above (please explain below)

Checklist:

  • My code follows the Code Guidelines of this project
  • My change requires a change to the documentation, either Doxygen or wiki
  • I have updated the documentation accordingly
  • I have read the Contributing document
  • I have added tests to cover my change
  • All new and existing tests passed

@a1rwulf a1rwulf requested a review from peak3d Apr 4, 2019

@kszaq kszaq force-pushed the kszaq:amlcodec_leia branch from 9b76ce1 to 8e68a2a Apr 7, 2019

@kszaq

This comment has been minimized.

Copy link
Contributor Author

commented Apr 7, 2019

Updated with suggestions and rebased on current master.

@peak3d

peak3d approved these changes Apr 8, 2019

@@ -1754,7 +1754,7 @@ bool CAMLCodec::OpenDecoder(CDVDStreamInfo &hints)

CLog::Log(LOGNOTICE, "CAMLCodec::OpenDecoder - using V4L2 pts format: %s", m_ptsIs64us ? "64Bit":"32Bit");

m_ptsOverflow = (sizeof(long) == 8) ? 0 : INT64_0;
m_ptsOverflow = 0;

This comment has been minimized.

Copy link
@peak3d

peak3d Apr 8, 2019

Contributor

For 64bit AML lib no PTSOverflow is reqired, are yousure that the logic change still works?
This change disables ptsOverflow for 32 bit AML libs now. My gut feeling is that the author has not fully understood the previous logic and changed by try.
But I'm Ok with all the changes here, because the AML lib support will hopefully die soon (V4L2)

This comment has been minimized.

Copy link
@kszaq

kszaq Apr 8, 2019

Author Contributor

It will still work as there is a check for arm/aarch64 in https://github.com/xbmc/xbmc/pull/15859/files#diff-4e99a88003816cb71e489e8a0db42345R1936

@kszaq kszaq force-pushed the kszaq:amlcodec_leia branch from 8e68a2a to 6f989c4 Apr 8, 2019

@kszaq

This comment has been minimized.

Copy link
Contributor Author

commented Apr 8, 2019

Force-pushed to solve the build issue I introduced when applying C++ style casts.

@kszaq

This comment has been minimized.

Copy link
Contributor Author

commented Apr 13, 2019

@peak3d Is this good to go? As you said, AMLCodec may no longer exist in v19, it would be nice to have these in v18.

@peak3d peak3d merged commit 92c12ca into xbmc:master Apr 13, 2019

1 check passed

default You're awesome. Have a cookie
Details

@Rechi Rechi added the v18 Leia label Apr 13, 2019

@Rechi Rechi added this to the Leia 18.2-rc1 milestone Apr 13, 2019

@kszaq kszaq deleted the kszaq:amlcodec_leia branch Apr 13, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.