Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[python] update WindowXML docs #15860

Merged
merged 1 commit into from Apr 6, 2019

Conversation

Projects
None yet
3 participants
@ronie
Copy link
Member

commented Apr 3, 2019

  1. the example of how to create a xml window was incorrect.
  2. provide a list of valid values for the defaultRes param
ronie
@@ -44,7 +44,7 @@ namespace XBMCAddon
/// skins path to look in for the xml.
/// (default='Default')
/// @param defaultRes [opt] string - default skins resolution.
/// (default='720p')
/// (1080i, 720p, ntsc16x9, ntsc, pal16x9 or pal. default='720p')

This comment has been minimized.

Copy link
@enen92

enen92 Apr 4, 2019

Member

Where is this defined in the code? Maybe we can just link to it if it is an enumeration and avoid changing it all the time

This comment has been minimized.

Copy link
@ronie

ronie Apr 4, 2019

Author Member

https://github.com/xbmc/xbmc/blob/master/xbmc/addons/Skin.cpp#L354-L372
i wouldn't worry to much about it, this code hasn't changed in 10 years.

This comment has been minimized.

Copy link
@enen92

enen92 Apr 4, 2019

Member

Yeap, makes sense. Ok for me

@enen92

enen92 approved these changes Apr 4, 2019

@ronie ronie merged commit 60bbf85 into xbmc:master Apr 6, 2019

1 check passed

default You're awesome. Have a cookie
Details

@Rechi Rechi added this to the Leia 18.2-rc1 milestone Apr 6, 2019

@ronie ronie deleted the ronie:py-xml branch May 7, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.