Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Music]Fix art loading for music located on server #15867

Merged
merged 1 commit into from Apr 10, 2019

Conversation

Projects
None yet
3 participants
@DaveTBlake
Copy link
Member

commented Apr 6, 2019

Fixes issue raised on forum https://forum.kodi.tv/showthread.php?tid=342699
When music is in the library but served up over HTTP, while album and artist art art shows when played from a songs node, it does not when using partymode or when play started from artist or album context menu. Both player OSD and current playlist screen are missing the art.

This is possible fallout from the addition of dynpath, which is set to the actual file location and thus starts "http". IsInternetStream uses that since #13648 and returns true, whereas previously for library items path shows the item is in library (thus can have art).

Add a check if item is in music db before skipping art loading because it is an internet stream

Fix loader skipping music files that are in library but located on a …
…server hence have dynpath starting "HTTP" and IsInternetStream returns true.

@DaveTBlake DaveTBlake force-pushed the DaveTBlake:ServerMusicArtFix branch from 40ba54d to 6b261b7 Apr 6, 2019

@sualfred

This comment has been minimized.

Copy link

commented Apr 6, 2019

Tested and I can confirm that Player.Art() and MusicPlayer.Cover gets filled again for partymode playlists and playback from artist/album node.

@DaveTBlake DaveTBlake added this to the Leia 18.2-rc1 milestone Apr 6, 2019

@DaveTBlake

This comment has been minimized.

Copy link
Member Author

commented Apr 8, 2019

@notspiff this look a sane way to fix this to you? IsInternetStream was checking path which was a library path, now it uses dynpath which can be the remote music file starting "HTTP" for even library entries.

@arnova

This comment has been minimized.

Copy link
Member

commented Apr 9, 2019

@DaveTBlake : While you're at it, I guess those IsInternetstream()-calls should (also) check whether they're on a LAN. So: IsInternetstream() && !URIUtils::IsOnLAN(). Also see #15069

@DaveTBlake

This comment has been minimized.

Copy link
Member Author

commented Apr 10, 2019

@arnova in this case I don't think an IsOnLAN check is correct here. This is about skipping attempting to load art and info from the music library, actions that are only valid when the item is a library entry. The video example you gave was about looking for art and NFO files that could be in the same location as the item (which could be over LAN).

Since this is tested and solves the bug I think best merged as it is so can be in fix in 18.2

@DaveTBlake DaveTBlake merged commit 01fc59d into xbmc:master Apr 10, 2019

1 check passed

default You're awesome. Have a cookie
Details

@DaveTBlake DaveTBlake deleted the DaveTBlake:ServerMusicArtFix branch Apr 10, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.