Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Find 3:2 pullback when searching for matching resolutions #15877

Merged
merged 1 commit into from Apr 8, 2019

Conversation

Projects
None yet
2 participants
@peak3d
Copy link
Contributor

commented Apr 8, 2019

Description

For monitors with restricted display modes (e.g. my BenQ has 50 / 59.9 / 60 Hz) it is hard to watch 50fps and 23.97fps without doing manual refreshrate operations.
This PR finds 59.9 for 23.9 media what looks much better compared to playing it on 50Hz.

Motivation and Context

No sufficient settng possible if kodi is setup for LiveTv (50Hz) but should modeswitch if watching common 23.97 streams.

How Has This Been Tested?

Android AFTV 2017:

  • Set Kodi GUI refreshrate to 50
  • Let whitelist empty
  • Play 23.97fps video

Types of change

  • Bug fix (non-breaking change which fixes an issue)
  • Clean up (non-breaking change which removes non-working, unmaintained functionality)
  • Improvement (non-breaking change which improves existing functionality)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that will cause existing functionality to change)
  • Cosmetic change (non-breaking change that doesn't touch code)
  • None of the above (please explain below)
@@ -143,11 +143,33 @@ void CResolutionUtils::FindResolutionFromWhitelist(float fps, int width, int hei
}
}

CLog::Log(LOGDEBUG, "No double whitelisted resolution matched, trying 3:2 pullback");

for (const auto &mode : indexList)
@@ -191,6 +213,24 @@ void CResolutionUtils::FindResolutionFromWhitelist(float fps, int width, int hei
}
}

CLog::Log(LOGDEBUG, "Default resolution doesn't provide reqired refreshrate, trying default resolution with 3:2 pullback");

for (const auto &mode : indexList)

This comment has been minimized.

Copy link
@Rechi

Rechi Apr 8, 2019

Member

left align &

@peak3d peak3d force-pushed the peak3d:3_2_pullback branch from b446bf4 to 52b3588 Apr 8, 2019

@peak3d peak3d force-pushed the peak3d:3_2_pullback branch from 52b3588 to d40beba Apr 8, 2019

@peak3d peak3d merged commit 4077a17 into xbmc:master Apr 8, 2019

1 check passed

default You're awesome. Have a cookie
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.