Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

X11: remove vdpau and glx #16057

Open
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
5 participants
@lrusak
Copy link
Contributor

commented May 3, 2019

It's time.

nvidia has been a constant thorn in the side of linux for a while now. vdpau is dead. glx is dead. let's get rid of it for V19.

torvalds + linux

@fritsch

This comment has been minimized.

Copy link
Member

commented May 4, 2019

There is one thing I wanted to have solved "upstream" before we do that to not punish AMD users that need VDPAU still for MPEG2, which is here: https://bugs.freedesktop.org/show_bug.cgi?id=110257

Other than that - one cannot stop future. It's a pitty and nvidia was long warned for that and did not react.

@FernetMenta

This comment has been minimized.

Copy link
Member

commented May 4, 2019

nvidia was long warned for that

funny :)

btw: vdpau is not dead. NVidia has just bumped it to 1.2

@pkerling

This comment has been minimized.

Copy link
Member

commented May 4, 2019

btw: vdpau is not dead. NVidia has just bumped it to 1.2

They seem to have resurrected it recently for exactly two commits (with the last change before that being in 2015!), adding HEVC444 support (= useless to us) ... It is still dead. Or maybe undead now? :-) Anyway, no EGL (= no Wayland, no Gbm), no VP8, no VP9, and there is no indication that that will change.

It's time.

I'm not sure to be honest. I do agree that it will have to go at some point, but do you think it is a maintenance burden at the present moment? If we remove functionality, I feel that we should have a good technical reason.

@lrusak

This comment has been minimized.

Copy link
Contributor Author

commented May 6, 2019

It's time.

I'm not sure to be honest. I do agree that it will have to go at some point, but do you think it is a maintenance burden at the present moment? If we remove functionality, I feel that we should have a good technical reason.

The technical reason is that keeping this hinders development on wayland and gbm as those platforms are not supported by vdpau. Dropping this ancient method will allow future development by forcing people to move on. By continuing to support this "just because we can" limits our future design, architecture, and development as a whole. This may seem like a stretch but I have been working in this area for a while now and without ripping the bandaid off nothing will ever change. Also by using git the history will always be there if by some miracle nvidia decides to drop the glx requirement from vdpau and moves it to egl where wayland and gbm may be able to use it (it would still require nvidia to provide gbm support in their binary blob driver). 💀

@arnova

This comment has been minimized.

Copy link
Member

commented May 7, 2019

@lrusak : Any idea how well Nouveau + VAAPI work nowadays? If that generally works fine I see no problem in dropping VDPAU.

@lrusak

This comment has been minimized.

Copy link
Contributor Author

commented May 7, 2019

@lrusak : Any idea how well Nouveau + VAAPI work nowadays? If that generally works fine I see no problem in dropping VDPAU.

It works but due to no reclocking support (yet) in nouveau playback is generally stuttery.
see, https://nouveau.freedesktop.org/wiki/VideoAcceleration/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.