Skip to content

build: quit guessing about intrinsics, check specifics #1626

Merged
merged 1 commit into from Oct 19, 2012

5 participants

@theuni
Team Kodi member
theuni commented Oct 15, 2012

Should be safe across the board unless I typo'd.

Quick darwin test would be appreciated before merging.

@ghost
ghost commented Oct 16, 2012

sign-offs for relevant platforms please.

@Memphiz
Team Kodi member
Memphiz commented Oct 16, 2012

osx:

macbook:xbmc-memphiz memphis$ grep HAS_BUILTIN xbmc/config.h
#define HAS_BUILTIN_SYNC_ADD_AND_FETCH 1
#define HAS_BUILTIN_SYNC_SUB_AND_FETCH 1
#define HAS_BUILTIN_SYNC_VAL_COMPARE_AND_SWAP 1

ios:

macbook:xbmc-ios memphis$ grep HAS_BUILTIN xbmc/config.h
#define HAS_BUILTIN_SYNC_ADD_AND_FETCH 1
#define HAS_BUILTIN_SYNC_SUB_AND_FETCH 1
#define HAS_BUILTIN_SYNC_VAL_COMPARE_AND_SWAP 1

and compiles on both

signed-off for osx/ios/atv2

@huceke
huceke commented Oct 16, 2012

signed-off for RaspberryPI

@theuni
Team Kodi member
theuni commented Oct 16, 2012

Fixed include, should be fine for win32 now. Thanks @wsoltys

@MartijnKaijser
Team Kodi member

Win32 builds ok

@Fneufneu
Team Kodi member

On amd64 FreeBSD with base gcc 4.2 and clang

#define HAS_BUILTIN_SYNC_ADD_AND_FETCH 1
#define HAS_BUILTIN_SYNC_SUB_AND_FETCH 1
#define HAS_BUILTIN_SYNC_VAL_COMPARE_AND_SWAP 1

and compile fine.

@ghost
ghost commented Oct 19, 2012

squash and inject cory.

@theuni theuni merged commit acae170 into xbmc:master Oct 19, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.