Use more information from AE in GUI #1643

Closed
wants to merge 9 commits into
from

Projects

None yet

6 participants

@Karlson2k
Team Kodi member

AE (SoftAE) know a lot of connected devices.
This PR enables usage of device information in GUI and maintain backward code compatibility.
I think that this way XBMC looks more solid and professional product.

@da-anda

why "passthroughaac" instead of "aacpassthrough" which would be in sync with the rest?

Team Kodi member

For historical reasons.

yeah - should be uniform - better as "aacpassthrough"

Team Kodi member

@DDDamian so it should be changed everywhere in code.
It will be separate PR.
May be it's better so use template "audiooutput.passthrough???"?

Sure - it's just for consistency, and it's a minor detail. Nice catch.

@da-anda

don't you missing aacpassthrough here?

Team Kodi member

No, 3 lines up.

@da-anda
Team Kodi member

dee9786 has it's own PR (sink reopen) - so I guess it's wrong in this one, isn't it?

@DDDamian DDDamian was assigned Oct 18, 2012
@Karlson2k
Team Kodi member

It's not a problem. If other PR will be merged, I'll rebase this one.

@davilla

Why acc at all ? I looked about for a receiver that handles acc passthough and came up empty.

@davilla

rather aac than acc, typo :)

@DDDamian

heh heh - tried this months ago......#1045

@DDDamian

@karlson2k - see my direct email about coordinating this - it's one we certainly want to bring in but don't want lots of conflicts while we wait for Frodo.

@da-anda
Team Kodi member

@fritsch @FernetMenta can stuff from here be reused for ActiveAE/new audio settings page or should it be closed?

@fritsch
Team Kodi member

There are some commits in the PR, that will be needed when we want to get the new Settings page in place. As those are quite a lot changes, I did not get an overview in time.

We have to organize such changes in a decent way, so that the PRs are not standing years and later don't come in or expire.

The new settings page can be used to see which features we are missing / need from the sink.

@MartijnKaijser
Team Kodi member

Should een handled wit he settings rework. Certain commit can be scavenged of this one if needed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment